Skip to content

Commit

Permalink
Add Cargo.lock to canister test cache key (#867)
Browse files Browse the repository at this point in the history
* Add Cargo.lock to canister test cache key

For unknown reasons, the Cargo.lock wasn't added to the cache key,
meaning that a Cargo.{lock,toml} update would not invalidate the cache.

* Add comment

* 🤖 Selenium screenshots auto-update

* 🤖 Selenium screenshots auto-update

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
nmattia and github-actions[bot] authored Sep 2, 2022
1 parent 0736166 commit e7c6911
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/canister-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,11 @@ jobs:
# note on paths: we include the whole ~/.cargo/. (as opposed to juse .cargo/git, etc) because cargo stores crate
# data as .crates(2?).{json,toml} without which the whole cache is invalidated. We may accumulate unnecessary
# stuff but the cache is anyway invalidated on every toolchain update.
# We also include all Cargo tomls and the lockfile
path: |
~/.cargo
target
key: ${{ runner.os }}-cargo-${{ hashFiles('src/**/Cargo.lock', 'rust-toolchain.toml') }}-2
key: ${{ runner.os }}-cargo-${{ hashFiles('Cargo.lock', 'Cargo.toml', 'src/**/Cargo.toml', 'rust-toolchain.toml') }}-2

- name: 'Download wasm'
uses: actions/download-artifact@v2
Expand Down
Binary file modified screenshots/00-welcome-desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified screenshots/24-authenticate-known-anchor-desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified screenshots/25-authenticate-unknown-anchor-desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit e7c6911

Please sign in to comment.