Skip to content

Commit

Permalink
Bump actions/checkout v3 -> v4 (#2238)
Browse files Browse the repository at this point in the history
This bumps the checkout action to the latest version. The previous
version (v3) ran on node 16 which is now deprecated on GHA.
  • Loading branch information
nmattia authored Jan 26, 2024
1 parent c0a5b70 commit f46da3b
Show file tree
Hide file tree
Showing 12 changed files with 35 additions and 35 deletions.
2 changes: 1 addition & 1 deletion .github/actions/file-size/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ A GitHub Action for recording file sizes in git notes.
record-readme-size:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ./.github/actions/file-size
with:
file: README.md
Expand Down
36 changes: 18 additions & 18 deletions .github/workflows/canister-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
docker-build-base:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# We use buildx and its GitHub Actions caching support `type=gha`. For
# more information, see
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
II_INSECURE_REQUESTS: 1

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Infer version
id: version
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:
runs-on: ubuntu-latest
needs: docker-build-ii
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Infer version
id: version
Expand Down Expand Up @@ -175,7 +175,7 @@ jobs:
runs-on: ubuntu-latest
needs: docker-build-base
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up docker buildx
uses: docker/setup-buildx-action@v2
Expand Down Expand Up @@ -205,7 +205,7 @@ jobs:
runs-on: ubuntu-latest
needs: docker-build-internet_identity_production
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: 'Download wasm'
uses: actions/download-artifact@v4
with:
Expand All @@ -230,7 +230,7 @@ jobs:
vc_demo_issuer-build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/cache@v3
with:
path: |
Expand Down Expand Up @@ -258,7 +258,7 @@ jobs:
test-app-build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/cache@v3
with:
path: |
Expand Down Expand Up @@ -289,7 +289,7 @@ jobs:
runs-on: ubuntu-latest
needs: [docker-build-ii, vc_demo_issuer-build]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/cache@v3
with:
path: |
Expand Down Expand Up @@ -340,7 +340,7 @@ jobs:
matrix:
os: [ ubuntu-latest, macos-latest ]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# Attempt to restore the pre-built test binaries from cache.
# The test binaries are only dependent on rust code, because the front-end code is bundled in the `wasm` file
Expand Down Expand Up @@ -410,7 +410,7 @@ jobs:
os: [ ubuntu-latest, macos-latest ]
partition: ['1/3', '2/3', '3/3']
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Download nextest
run: |
Expand Down Expand Up @@ -487,7 +487,7 @@ jobs:
artifact_suffix: ${{ contains(matrix.domain, 'internetcomputer') && 'current' || 'legacy' }}-${{ matrix.device }}-${{ matrix.shard }}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-node

# npm ci is a slow operation that mostly involves downloading packages, so we run
Expand Down Expand Up @@ -597,7 +597,7 @@ jobs:
runs-on: ubuntu-latest
needs: docker-build-ii
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- run: |
sudo apt-get update
Expand Down Expand Up @@ -658,7 +658,7 @@ jobs:
if: startsWith(github.ref, 'refs/tags/release-')
needs: [docker-build-internet_identity_production, docker-build-archive, test-app-build, vc_demo_issuer-build]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: ./.github/actions/setup-dfx

Expand Down Expand Up @@ -733,7 +733,7 @@ jobs:
needs: [docker-build-internet_identity_production, docker-build-archive, vc_demo_issuer-build]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: 'Download test build'
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -890,7 +890,7 @@ jobs:
cached-build:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/cache@v3
id: cache
with:
Expand Down Expand Up @@ -930,7 +930,7 @@ jobs:
runs-on: ubuntu-22.04
needs: [docker-build-ii, cached-build]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: 'Download docker build'
uses: actions/download-artifact@v4
with:
Expand Down Expand Up @@ -965,7 +965,7 @@ jobs:
# XXX: GHA fails if we return the matrix object directly, so we have to pretend it's JSON
os: ${{ github.ref == 'refs/heads/main' && fromJson('[ "ubuntu-22.04", "ubuntu-20.04", "macos-11", "macos-12" ]') || fromJson('[ "ubuntu-22.04" ]') }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ./.github/actions/check-build
- run: mv internet_identity.wasm.gz internet_identity_clean_build_${{ matrix.os }}.wasm.gz
- name: 'Upload clean build'
Expand Down Expand Up @@ -1020,7 +1020,7 @@ jobs:
interface-compatibility:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
# we need the history for the tags, but we don't need the files (except for the GitHub workflows / actions)
# --> sparse checkout of only the needed things
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-rc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
testnet_app_canister_id: jlfvx-nqaaa-aaaad-aab7a-cai
wallet_canister_id: cvthj-wyaaa-aaaad-aaaaq-cai
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: "Download build for Release Candidate"
uses: actions/github-script@v6
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/frontend-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
frontend-checks:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
# set a PAT so that add-and-commit can trigger CI runs
token: ${{ secrets.GIX_BOT_PAT }}
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
showcase:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-node
- run: npm ci

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-build-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
matrix:
os: [ ubuntu-22.04, ubuntu-20.04, macos-11, macos-12 ]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: "refs/tags/${{ needs.latest-release.outputs.ref }}"

Expand All @@ -86,7 +86,7 @@ jobs:
matrix:
os: [ ubuntu-22.04, ubuntu-20.04, macos-11, macos-12 ]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: "refs/tags/${{ needs.latest-release.outputs.ref }}"

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
cargo-fmt:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
# set a PAT so that add-and-commit can trigger
# CI runs
Expand Down Expand Up @@ -38,7 +38,7 @@ jobs:
cargo-clippy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ./.github/actions/bootstrap

- name: Create dummy assets
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
check-lockfile:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ./.github/actions/bootstrap

# fails if lockfile is out of date
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/screenshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ jobs:
# Make sure that one failing test does not cancel all other matrix jobs
fail-fast: false
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
if: ${{ matrix.ref == 'head' }}
- uses: actions/checkout@v3
- uses: actions/checkout@v4
if: ${{ matrix.ref == 'base' }}
with:
ref: ${{ github.event.pull_request.base.sha }}
Expand Down Expand Up @@ -90,7 +90,7 @@ jobs:
echo "dumpster_path=objs/$branch_alias" >> "$GITHUB_OUTPUT"
id: sys

- uses: actions/checkout@v3
- uses: actions/checkout@v4
# Checks out 'image-dumpster', a single-commit branch used to keep objects (screenshots).
# We store the images in a branch (as opposed to e.g. artifacts) so that GitHub will serve
# them (on rawgithubusercontent), meaning we can display them on PRs.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-dapps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
dapps-update:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-node
- run: npm ci

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-didc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
didc-update:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# First, check didc releases (on the candid repo) for a new version.
- name: Check new didc version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
node-update:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# First, check node's releases for a new version.
- name: Check new node version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
rust-update:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# First, check rust GitHub releases for a new version. We assume that the
# latest version's tag name is the version.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-state-machine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
ic-update:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# First, check if there is a newer version and update the file referencing the version
- name: Check new ic version
Expand Down

0 comments on commit f46da3b

Please sign in to comment.