Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch vc_util to a minimal iota-fork #2475

Merged
merged 9 commits into from
May 29, 2024
Merged

Conversation

przydatek
Copy link
Collaborator

@przydatek przydatek commented May 16, 2024

Switch vc_util to depend on a new iota-VC-library fork that contains minimal changes to work with IC/canister signatures.


🟡 Some screens were changed

@przydatek przydatek marked this pull request as ready for review May 28, 2024 14:34
Copy link
Contributor

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you know why there are so many additional dependencies in the Cargo.lock files?

@przydatek
Copy link
Collaborator Author

Thanks! Do you know why there are so many additional dependencies in the Cargo.lock files?

Probably because the iota-library has evolved since August 2023 (our old fork is 92 commits and 10 releases behind). I believe we can cut some options in the crates we're using, and so reduce the dependencies. I'll do some experiments.
Currently the switch to the updated fork increases the size of vc_issuer-binary by about 33kB (roughly 3%):

-rw-r--r-- 1 890774 May 29 15:32 vc_demo_issuer--old-iota.wasm.gz
-rw-r--r-- 1 923056 May 28 16:15 vc_demo_issuer--updated-iota.wasm.gz

@przydatek przydatek added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 989a891 May 29, 2024
65 checks passed
@przydatek przydatek deleted the bartosz/vc-util-min-iota-fork branch May 29, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants