Add test-canisters.sh script to CI #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuntaner
force-pushed
the
lm-add-test-canisters-script-ci
branch
from
7275d77 to
97b5adb
Compare
| @@ -391,6 +390,20 @@ jobs: | |||
| env: | |||
| RUST_BACKTRACE: 1 | |||
|
|
|||
| test-canisters-script: | |||
There was a problem hiding this comment.
This job takes more than 10 minutes, so it is immediately the slowest thing in the whole pipeline. I would not add it without any caching.
For reference, the normal pipeline with caching takes ~6m 30s.
There was a problem hiding this comment.
I added the --no-build parameter and used the built wasms. It takes 6'30" now. Is this reasonable?
It depends on a few other jobs though. Therefore, the whole CI is probably slower now.
I could add pocket-ic and the other dependencies into a cache and use it as well. Maybe in another PR?
lmuntaner
force-pushed
the
lm-add-test-canisters-script-ci
branch
2 times, most recently
from
6ce4473 to
a01452f
Compare
|
@frederikrothenberger ready for another review. The duration is now down to 2min. |
frederikrothenberger
approved these changes
Oct 23, 2024
|
|
||
| - name: Run tests | ||
| run: | | ||
| ./scripts/test-canisters.sh --no-build should_keep_new_anchor_across_rollback |
There was a problem hiding this comment.
Maybe add a comment on how you chose these particular tests?
lmuntaner
force-pushed
the
lm-add-test-canisters-script-ci
branch
from
20a2520 to
024464d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make sure that test-canisters.sh script is kept up-to-date in case something else is needed to run tests.
Changes
Add a test in CI to run the tests with this script.
🟡 Some screens were changed