Add "derivationOrigin" to id_alias credential #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frederikrothenberger please review |
lmuntaner
force-pushed
the
lm-add-origin-vc-id-alias
branch
from
fd1809b to
a69e19a
Compare
frederikrothenberger
approved these changes
Oct 23, 2024
1 task
lmuntaner
added a commit
to dfinity/verifiable-credentials-sdk
that referenced
this pull request
Oct 24, 2024
# Motivation Fix issue raised here: https://dfinity.atlassian.net/browse/FOLLOW-1651 which is already merged in II: dfinity/internet-identity#2664 # Changes * Add parameter `expected_derivation_origin` to `AliasTuple` and to verify functions. Use the new param to check the claims of the id alias credential. # Tests There were some hidden dependencies among tests and constants used. For example, the expiration was the same in all the credentials. * I created new variables and scoped the dependencies within the test if possible. * I kept some JWS because they are hard to replicate and there was no need to redo again. Those are the ones that use a local IC root key. * I added new JWS with the new id_alias used for most of the tests. * I added two new tests. One to check that a wrong derivation origin raises an error and another one that the verification fails with the old JWS. # Todos - [x] Add entry to changelog (if necessary).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix issue raised here: https://dfinity.atlassian.net/browse/FOLLOW-1651
Changes
derivationOriginfield to the id_alias credential.AliasTuplefrom vc-sdk. It created a dependency when I wanted to change it. Therefore, I assumed it should not come from the sdk because it's just a helper type within the II implementation.I will add
derivationOriginto theAliasTuplein the sdk as well, but I believe those two types shouldn't be reused because it creates this dependency where the SDK needs to change for II to use the change, and then the SDK needs to use the new change again. There is no need for this flow with this shared type because it's just a helper type here.Testing
I deployed locally and checked with the dummy relying party and issuer that the new field is added.
However, the integration tests rely on the VC SDK which still doesn't validate the new field. As soon as we add this validation, we should upgrade the dependency in II and the new field would be validated as well.
🟡 Some screens were changed