fix: Use lower case for Wasm persistence modes #4854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might have been easier to just change the spec to match the implementation ;-> |
Yes, I was also tempted. But better going this more painful path to keep IC specification more consistent (reducing "technical debt"). |
…/dfinity/motoko into luc/lower-case-persistence-modes
luc-blaeser
changed the title
crusso
approved these changes
Jan 17, 2025
|
LGTM. |
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jan 17, 2025
Change variant names for the Wasm memory persistence to lower case in line with the IC specification, i.e. using `keep` and `replace` instead of `Keep` and `Replace`. The Wasm memory persistence option is used for Motoko's enhanced orthogonal persistence, which is currently still in beta testing. The following components need to be updated once these changes are released on IC mainnet and `dfx`: * The Motoko compiler (dfinity/motoko#4854) * The Motoko playground (dfinity/motoko-playground#275) No change is needed for `dfx`. For installed Motoko programs using enhanced orthogonal persistence, the change only affects the programmatic upgrades of Motoko actor class instances. Existing such programs would need to be recompiled with a new Motoko compiler and upgraded. The IC detects mismatching variant names of Wasm memory persistence by raising an error while still preserving persistent memory.
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jan 17, 2025
Change variant names for the Wasm memory persistence to lower case in line with the IC specification, i.e. using `keep` and `replace` instead of `Keep` and `Replace`. The Wasm memory persistence option is used for Motoko's enhanced orthogonal persistence, which is currently still in beta testing. The following components need to be updated once these changes are released on IC mainnet and `dfx`: * The Motoko compiler (dfinity/motoko#4854) * The Motoko playground (dfinity/motoko-playground#275) No change is needed for `dfx`. For installed Motoko programs using enhanced orthogonal persistence, the change only affects the programmatic upgrades of Motoko actor class instances. Existing such programs would need to be recompiled with a new Motoko compiler and upgraded. The IC detects mismatching variant names of Wasm memory persistence by raising an error while still preserving persistent memory.
|
We can merge. It is supported in next IC release. |
Yep, but let's not forget that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dfinity/ic#3479.
This changes the variant names for the Wasm memory persistence modes used for enhanced orthogonal persistence to lower case to align it with the IC specification, i.e. using
keepandreplaceinstead ofKeepandReplace.For installed Motoko programs using enhanced orthogonal persistence, the change only affects the programmatic upgrades of Motoko actor class instances. Existing such programs would need to be recompiled with a new Motoko compiler and upgraded. The IC detects mismatching variant names of Wasm memory persistence by raising an error while still preserving persistent memory.