Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devops): Create the cycles depositor args automatically #1

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

bitdivine
Copy link
Member

@bitdivine bitdivine commented Sep 17, 2024

Motivation

The cycles depositor needs to know the cycles ledger canister ID. It gets it from the install arg. Currently this is provided manually but could be provided automatically, thereby supporting dfx deploy cycles_depositor with no further input.

Changes

  • Generate the cycles_depositor args automatically.

Tests

This works locally:

dfx deploy cycles_ledger
dfx deploy cycles_depositor

@bitdivine bitdivine merged commit d8fc01c into main Sep 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant