Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(icrc2 cycles): Split icrc2 cycles payment into two #30

Merged
merged 4 commits into from
Oct 1, 2024
Merged

refactor(icrc2 cycles): Split icrc2 cycles payment into two #30

merged 4 commits into from
Oct 1, 2024

Conversation

bitdivine
Copy link
Member

Motivation

Combining the icrc2 payment guards makes the guard more complex and makes it possible to misconfigure.

Changes

  • Split the icrc2 cycles payment guard into two.
    • Note: Each half is the same as the original, unchanged apart from renaming.

Tests

Existing CI should suffice.

@bitdivine bitdivine marked this pull request as ready for review October 1, 2024 09:44
@bitdivine bitdivine enabled auto-merge (squash) October 1, 2024 09:44
@bitdivine bitdivine merged commit 005a75c into main Oct 1, 2024
9 checks passed
@bitdivine bitdivine deleted the api branch October 1, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bitdivine