Fix otp27 compilation #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for OTP-27
So it compiles on OTP-27
dgud
force-pushed
the
dgud/fix-otp27
branch
from
453a21f to
0ca3e2a
Compare
|
@elblake can't add you as a reviewer for some reason, please take a look. |
|
I'm not too sure how it works, I didn't find anything in settings to change. I think I'll be able to follow along though. |
|
I needed to add you as a collaborator :-) |
dgud
force-pushed
the
dgud/fix-otp27
branch
2 times, most recently
from
7f3c113 to
4a64e33
Compare
Micheus
reviewed
Sep 25, 2024
| @@ -64,7 +64,7 @@ jobs: | |||
| - name: Download win32 Erlang | |||
There was a problem hiding this comment.
@dgud, the Erlang VM isn't a real 64bits app?
There was a problem hiding this comment.
Win32 is the API name on windows. Have nothing todo (today) with the number of bits on the processor.
dgud
force-pushed
the
dgud/fix-otp27
branch
from
a6df64f to
bf4d0c8
Compare
|
Ok I'm gonna merge this, since I need it to test the other branches. |
|
I'll take a closer look pretty soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.