fix(verify-bundle): add support for top-level directories #691
Conversation
| form.append( | ||
| 'file', | ||
| fs.createReadStream( | ||
| path.join(__dirname, '../', 'sample-app-top-level.zip') |
There was a problem hiding this comment.
when I open up this zip file, it didn't look like there was an extra top-level layer? So I'm not sure how the test is different than the should create an app (but maybe I'm missing something or this is due to my OS or something)?
|
Hi @Birkbjo - I'm cleaning up open reviews that have been requested from me and I see that this never got merged... is it waiting on something or did it already get fixed elsewhere so this PR can be closed? Happy new year! |
|
@amcgee Don't think this is waiting on anything. You merged the same functionality in core, so I guess I just waited for your approval. |
|
@Birkbjo following up on this again, no need to wait for my approval - feel free to update and merge |
|
Adds support for top-level directories in app-bundles.
Related to dhis2/dhis2-core#11831