Skip to content

Commit

Permalink
test: un-skip integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
KaiVandivier committed Nov 22, 2024
1 parent f66bbf2 commit 433f760
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions services/offline/src/__tests__/integration.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ describe('Coordination between useCacheableSection and CacheableSection', () =>
expect(getByTestId(/controls-rc/)).toBeInTheDocument()
})

it.skip('handles a successful recording', async (done) => {
it('handles a successful recording', async (done) => {
const { getByTestId, queryByTestId } = screen

const onStarted = () => {
Expand Down Expand Up @@ -147,7 +147,7 @@ describe('Coordination between useCacheableSection and CacheableSection', () =>
expect.assertions(7)
})

it.skip('handles a recording that encounters an error', async (done) => {
it('handles a recording that encounters an error', async (done) => {
// Suppress the expected error from console (in addition to 'act' warning)
jest.spyOn(console, 'error').mockImplementation((...args) => {
const actPattern =
Expand Down Expand Up @@ -255,7 +255,7 @@ describe('Performant state management', () => {
expect(getByTestId('section-rc-2')).toHaveTextContent('1')
})

it.skip('isolates rerenders from other consumers', async (done) => {
it('isolates rerenders from other consumers', async (done) => {
const { getByTestId } = screen
// Make assertions
const onCompleted = () => {
Expand Down Expand Up @@ -300,7 +300,7 @@ describe('useCacheableSection can be used inside a child of CacheableSection', (
)
}

it.skip('handles a successful recording', async (done) => {
it('handles a successful recording', async (done) => {
const { getByTestId, queryByTestId, findByTestId } = screen

Check warning on line 304 in services/offline/src/__tests__/integration.test.tsx

View workflow job for this annotation

GitHub Actions / lint

'findByTestId' is assigned a value but never used

Check warning on line 304 in services/offline/src/__tests__/integration.test.tsx

View workflow job for this annotation

GitHub Actions / lint

'findByTestId' is assigned a value but never used

const onStarted = async () => {
Expand All @@ -326,9 +326,9 @@ describe('useCacheableSection can be used inside a child of CacheableSection', (

render(<ChildTest makeRecordingHandler={makeRecordingHandler} />)

// await act(async () => {
await fireEvent.click(getByTestId(/start-recording/))
// })
await act(async () => {
await fireEvent.click(getByTestId(/start-recording/))
})

await waitFor(() => {
// At this stage, should be pending
Expand Down

0 comments on commit 433f760

Please sign in to comment.