fix: move height/width out of styles

dhis2 · Sep 9, 2024 · 737b238 · 737b238
1 parent 5868050
commit 737b238
Showing 1 changed file with 2 additions and 15 deletions.
diff --git a/services/plugin/src/Plugin.tsx b/services/plugin/src/Plugin.tsx
@@ -24,13 +24,6 @@ const getPluginEntryPoint = ({
     )?.pluginLaunchUrl
 }
 
-const getIframeDimension = (dimension: string): string => {
-    if (!isNaN(Number(dimension))) {
-        return `${Number(dimension)}px`
-    }
-    return dimension
-}
-
 export const Plugin = ({
     pluginSource,
     pluginShortName,
@@ -150,15 +143,9 @@ export const Plugin = ({
             <iframe
                 ref={iframeRef}
                 src={pluginSource}
+                width={width ?? resizedWidth + 'px'}
+                height={height ?? resizedHeight + 'px'}
                 style={{
-                    width: `${
-                        width ? getIframeDimension(width) : resizedWidth + 'px'
-                    }`,
-                    height: `${
-                        height
-                            ? getIframeDimension(height)
-                            : resizedHeight + 'px'
-                    }`,
                     border: 'none',
                 }}
             ></iframe>