fix(deps): test out circular dependency as infinite install loop cause #1378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: actually, I don't think a circular dependency is causing the loop that ends with
multi-calendar-dates
and starts withcli-app-scripts
and indicates a version conflict for React. Afteralpha.1
of app-runtime where thecli-app-scripts
version conflict was fixed, app-runtime still has a dev dependency on cli-app-scripts, but no longer loops.@dhis2/multi-calendar-dates
and@dhis2/ui
both have only a dev dependency oncli-app-scripts
as well (not a peer dep likeapp-runtime
had beforealpha.1
), so those wouldn't be expected to loop because of that dependencyEither peer dependency version conflicts or circular dependencies can cause infinite loops during the NPM install -- adding this circular dependency but not a version conflict will test if circular dependencies do indeed cause loops, or if it's just version conflicts
Part of LIBS-587