Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update plugin sizing definition [LIBS-631] #1383

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Jun 21, 2024

Implements LIBS-631


Key features

Moves Plugin wrapper's definition of iframe dimensions from parent div to iframe. This is equivalent, but prevents errors with highcharts visualiztion resizing in dashboard. I have tested and this does not affect the resizing logic for plugins that are supposed to auto resize.

Checklist

  • Have written Documentation
    • This change does not affect the Plugin wrapper interface, but is rather an internal implementation detail
  • Has tests coverage
    • No. We need to add tests for Plugin wrapper as part of work to make non-experimental

@tomzemp tomzemp requested review from KaiVandivier, a team and edoardo June 21, 2024 13:44
@tomzemp tomzemp merged commit 266dc49 into master Jun 24, 2024
16 checks passed
@tomzemp tomzemp deleted the LIBS-631/plugin-iframe-dimensions branch June 24, 2024 09:13
dhis2-bot added a commit that referenced this pull request Jun 24, 2024
## [3.10.5](v3.10.4...v3.10.5) (2024-06-24)

### Bug Fixes

* update plugin sizing definition ([#1383](#1383)) ([266dc49](266dc49))
@dhis2-bot
Copy link
Contributor

KaiVandivier pushed a commit that referenced this pull request Nov 25, 2024
* update plugin sizing definition ([#1383](#1383)) ([266dc49](266dc49))
dhis2-bot added a commit that referenced this pull request Nov 26, 2024
# [3.11.0-alpha.1](v3.10.4-alpha.1...v3.11.0-alpha.1) (2024-11-26)

### Bug Fixes

* **cacheable-section:** synchronously flush recording state for UI consistency ([04bc604](04bc604))
* add endpoint to text plain matchers ([#1390](#1390)) ([de8fbec](de8fbec))
* expand FetchErrorDetails type ([#1389](#1389)) ([78ad0b3](78ad0b3))
* handle alert returned async by parentAlertsAdd [LIBS-695] ([#1388](#1388)) ([bba9c23](bba9c23))
* **cacheable-section:** stable references to avoid loops [LIBS-642] ([#1385](#1385)) ([31562e9](31562e9))
* update plugin sizing definition ([#1383](#1383)) ([38c09b9](38c09b9))
* **deps:** remove cli-app-scripts peer dep [LIBS-587] ([#1379](#1379)) ([9e22e88](9e22e88))
* **deps:** update cli-app-scripts for package/types race condition ([dee6795](dee6795))

### Features

* fixed dimensions efficiency ([#1386](#1386)) ([b56ad2d](b56ad2d))
* upgrade app-runtime React version to v18 ([#1387](#1387)) ([0e4a3d5](0e4a3d5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants