feat: [DHIS2-16782] Changelog sorting and filtering by user and data item #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @henrikmv, it looks good overall, I just added 2 small comments.
| ) => { | ||
| const { dataElement, attribute, field } = change; | ||
| const fieldId = dataElement ?? attribute ?? field; | ||
| // Hjelpefunksjon for å hente riktig metadata |
There was a problem hiding this comment.
There are some comments and logs in Norwegian in this file. Can you please remove the comments and change the logs to English? Thank you!
| @@ -32,22 +31,35 @@ export const useChangelogData = ({ | |||
| setPageSize(newPageSize); | |||
| }; | |||
|
|
|||
| const filterParam = | |||
| filterValue !== 'Show all' && attributeToFilterBy | |||
There was a problem hiding this comment.
The value sent from ChangelogFilterBar is SHOW_ALL, so this check does not work correctly. The const initialization on line 24 should probably be changed to const [filterValue, setFilterValue] = useState('SHOW_ALL');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-16782:
UserandData itemData item(For the attributes: DataElement and Field)