-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [DHIS2-8087] Add empty launch page #3940
base: master
Are you sure you want to change the base?
Conversation
🚀 Deployed on https://deploy-preview-3940.capture.netlify.dhis2.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eirikhaugstulen, to better align it with the design in the Jira ticket, I added a few comments with some minor CSS tweaks.
...re_modules/capture-core/components/Pages/MainPage/NoSelectionsInfoBox/NoSelectionsInfoBox.js
Outdated
Show resolved
Hide resolved
...re_modules/capture-core/components/Pages/MainPage/NoSelectionsInfoBox/NoSelectionsInfoBox.js
Outdated
Show resolved
Hide resolved
...re_modules/capture-core/components/Pages/MainPage/NoSelectionsInfoBox/NoSelectionsInfoBox.js
Show resolved
Hide resolved
Hey @simonadomnisoru - sorry this PR was meant to be in draft mode 😅 I totally agree with you that the design differs a bit, the idea was that we would bridge the gap a bit between this and the other feedback box (Therefore a similar gap, marginTop and so on). However, I thought it felt a bit wrong, so wanted Joe and Karoline to have a look. I'll update once they've looked through it 👍 |
…first-launch-state # Conflicts: # i18n/en.pot
Quality Gate passedIssues Measures |
Rewritten with updated styling @simonadomnisoru! |
</svg> | ||
); | ||
|
||
const documentationLink = 'https://docs.dhis2.org/en/use/user-guides/dhis-core-version-master/tracking-individual-level-data/capture.html'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Eirik,
In my mind, this documentation was always intended only for the instance admins and implementers. Do we want the regular DHISS2 user to see it? If we do want to add the documentation link inside the app, then I think we should build the documentationLink
based on the server version. Something like this:
https://docs.dhis2.org/en/use/user-guides/dhis-core-version-{serverVersion.major}{serverVersion.minor}/tracking-individual-level-data/capture.html
WDYT? Thank!
Summary: