chore: use button instead of span since element is interactive

dhis2 · Jan 14, 2025 · e737240 · e737240
1 parent 5812fc5
commit e737240
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/pages/edit/ItemSelector/ContentMenuItem.js b/src/pages/edit/ItemSelector/ContentMenuItem.js
@@ -12,13 +12,13 @@ const LaunchLink = ({ url }) => {
     }, [url])
 
     return (
-        <span
+        <button
             onClick={handleClick}
-            className={classes.launchLink}
+            className={classes.launchLinkButton}
             aria-label={i18n.t('Open visualization in new tab')}
         >
             <IconLaunch16 color={colors.grey700} />
-        </span>
+        </button>
     )
 }
 

diff --git a/src/pages/edit/ItemSelector/styles/ContentMenuItem.module.css b/src/pages/edit/ItemSelector/styles/ContentMenuItem.module.css
@@ -4,10 +4,13 @@
     justify-content: space-between;
 }
 
-.launchLink {
+.launchLinkButton {
     display: flex;
     margin-inline-start: 8px;
     z-index: 10000;
+    border: none;
+    background-color: transparent;
+    padding: 0;
 }
 
 .label {