chore: [ANDROSDK-1973] Move TrackedEntityType api logic to network layer #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgarciabnz
reviewed
Jan 14, 2025
Jenkinsfile
Outdated
| @@ -42,7 +50,11 @@ pipeline { | |||
| script { | |||
| echo 'Browserstack deployment and running tests' | |||
| sh 'chmod +x ./scripts/browserstackJenkins.sh' | |||
| sh './scripts/browserstackJenkins.sh' | |||
| retry(20) { // Retry up to 3 times | |||
| timeout(time: 5, unit: 'MINUTES') { | |||
There was a problem hiding this comment.
I think 5 minutes is not enough for instrumented tests
There was a problem hiding this comment.
No, I changed retries instead of minutes, it should be 20
vgarciabnz
requested changes
Jan 14, 2025
|
|
||
| internal fun interface TrackedEntityTypeNetworkHandler { | ||
| suspend fun getTrackedEntityTypes( | ||
| optionSetUids: Set<String>, |
|
|
||
| @Test | ||
| override fun map_from_json_string() { | ||
| val entityType = objectMapper.readValue(jsonStream, TrackedEntityType::class.java) | ||
| val EntityTypeDTO = deserialize(TrackedEntityTypeDTO.serializer()) |
|
vgarciabnz
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related task: ANDROSDK-1973