Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using a clustered setup with Redis enabled, the session timeout setting is not honored.
Cause
Session timeout must be set on the
RedisIndexedSessionRepository
when enabled, rather than only in theDhisHttpSessionEventListener
, which is ignored when Spring Session is used.Fix
Set the session timeout directly on the
RedisIndexedSessionRepository
on startup.Use the
NonRedisSessionConfig
to set the session timeout with an event listener, only when Redis is not enabled.Remove the redundant
DhisHttpSessionEventListener
class.Manual test (minimal setup)
redis.enabled = true
(will assume port 6379 and localhost)system.session.timeout = 120
Test without Redis enabled.
redis.enabled = true
Manual test (multiple servers)
JIRA: DHIS2-18460