fix(types): add support for size and rename fieldtransformers #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
flaminic
reviewed
Dec 9, 2024
| @@ -75,3 +111,14 @@ export type PickWithFieldFilters< | |||
| > | |||
| > | |||
| > | |||
|
|
|||
| // type Test = PickWithFieldFilters< | |||
There was a problem hiding this comment.
ANy reason why you want to keep this code in?
flaminic
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im not sure if we want to maintain or use this anymore - and we could probably get away by using our
zod-schemas as a source of truth for the types...We recently used
size and renamefield transformers incategoryCombos/Editto get the number ofcategoryOptionswithincategory. . This would cause the inferred type fromPickWithFieldFiltersto be incorrect. This should add support for ~rename and ~size field-transformers.original~rename(newName)will rename the property in the type.~sizewill cause the type of the property to be number. Note that there's no real validation on this, is just enforces the type to be number.categories[id,displayName]~rename(cat). This also does not work in the API, so it makes sense: http://localhost:8080/api/categoryCombos?fields=id,name,categories[id,name]~rename(cat)categories[id, displayName, categoryOptions~size~rename(optionSize)