feat: org uni group forms #479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Birkbjo
reviewed
Jan 8, 2025
| ModelTransferField, | ||
| } from '../../../components' | ||
| import { SECTIONS_MAP } from '../../../lib' | ||
| import { DataDimensionField } from '../../dataElementGroupSets/fields' |
There was a problem hiding this comment.
There's some unused imports here.
Birkbjo
reviewed
Jan 8, 2025
|
|
||
| generateDefaultEditFormTests({ componentName: 'Organisation unit group' }) | ||
|
|
||
| xdescribe('Organisation unit group edit form additional tests', () => { |
There was a problem hiding this comment.
typo?
Suggested change
| xdescribe('Organisation unit group edit form additional tests', () => { | |
| describe('Organisation unit group edit form additional tests', () => { |
Birkbjo
reviewed
Jan 8, 2025
| </StandardFormField> | ||
| <StandardFormField> | ||
| <FieldRFF | ||
| component={CheckboxFieldFF} |
There was a problem hiding this comment.
I noticed that it seems like the label/clickable area for CheckboxField spans the entire width of the form. This is of course not something introduced in this PR. But may be something we want to take a look at? The easiest solution is to add display: flex to StandardFormField , I think? But we've also talked about removing the need for the StandardFormField-wrappers, and instead add gap to StandardFormSection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.