feat: add email verification in user list [DHIS2-18613] #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomzemp
commented
Jan 15, 2025
| }) => ({ | ||
| fields: [ | ||
| 'id', | ||
| 'displayName', | ||
| 'access', | ||
| 'email', | ||
| 'emailVerified', |
There was a problem hiding this comment.
this is now added to the request regardless, but will not be returned if it does not exist / will not be displayed if the conditions for this feature are not met.
I didn't think it was worth it to change the query definition based on the feature logic
|
🚀 Deployed on https://pr-1520--dhis2-user.netlify.app |
tomzemp
commented
Jan 15, 2025
tomzemp
commented
Jan 15, 2025
| # And the user-manager navigated to the user list view | ||
| # When the user-manager searches the list by entering a name | ||
| # Then only the users whose username or display name contains the search term should be displayed | ||
| Scenario: The user list gets filtered by name |
There was a problem hiding this comment.
unrelated, but turning these back on because the issue with them is now resolved on the backend
Chisomchima
requested changes
Jan 15, 2025
There was a problem hiding this comment.
I think we can set the default selected value of the SingleSelectField to "all", ensuring that when the component is first loaded, the "All" option is selected by default.
<SingleSelectField
prefix={i18n.t('Email verification')}
selected={emailVerificationStatus ? emailVerificationStatus : 'all'} // Default to 'all' if no status is provided
onChange={({ selected }) =>
onEmailVerificationStatusChange(selected)
}
className={styles.input}
dense
>
<SingleSelectOption label={i18n.t('All')} value="all" /> // Default option
<SingleSelectOption label={i18n.t('Email verified')} value="true" />
<SingleSelectOption label={i18n.t('Email not verified')} value="false" />
</SingleSelectField>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
See https://dhis2.atlassian.net/browse/DHIS2-18613
If system is v42+ and system has email configured, then the user list will display information about email verification status as well as a filter for this status.
(note when looking at this PR, you can simply put fake values in the email hostname, username as the system assume email is configured if these values are present)
Testing
Manually tested against v41 and v42 (with v42 with and without email configured)
added automated tests (jest) for