-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for commit prefix #160
base: dev
Are you sure you want to change the base?
Changes from 7 commits
83a919b
098db00
b15a100
abb488e
2577ec1
4f6e95a
148773e
52122de
dae0408
e0d1850
5021017
af6f99b
59bc005
a82f8d0
02d0171
140761c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,8 @@ export enum CONFIG_KEYS { | |
description = 'description', | ||
emoji = 'emoji', | ||
model = 'model', | ||
language = 'language' | ||
language = 'language', | ||
prefix = 'prefix' | ||
} | ||
|
||
export enum CONFIG_MODES { | ||
|
@@ -109,7 +110,17 @@ export const configValidators = { | |
`${value} is not supported yet, use 'gpt-4' or 'gpt-3.5-turbo' (default)` | ||
); | ||
return value; | ||
}, | ||
|
||
[CONFIG_KEYS.prefix](value: any) { | ||
validateConfig( | ||
CONFIG_KEYS.prefix, | ||
true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. true is not validating anything here :) we should validate the config input with a function or expression which return Boolean There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @di-sukharev Do you have an idea what can we validate? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you somehow need to confirm that the value is the exact format you expect, if your format is |
||
'Cannot be empty' | ||
); | ||
return value; | ||
} | ||
|
||
}; | ||
|
||
export type ConfigType = { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this going to add the full branch name in the commit like:
#234-some-branch-name commit message text goes here
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it will take a regex out of the name. See my first commit on this PR.
Very cool to hear about the hackathon!