fnal adjustments to shadow dom subject details, closes #40

digas99 · Nov 21, 2024 · e457814 · e457814
1 parent 4d72094
commit e457814
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/popup/scripts/subject.js b/popup/scripts/subject.js
@@ -71,6 +71,11 @@ chrome.storage.local.get(fetchKeys, async result => {
 
 	await details.create(true);
 
+	// remove menu button
+	const menuButton = document.querySelector("#sd-detailsPopupMenu");
+	if (menuButton)
+		menuButton.remove();
+
 	wrapper.addEventListener("click", e => {
 		if (e.target.closest(".sd-detailsPopup_cardSideBarInfo")) {
 			const card = e.target.closest(".sd-detailsPopup_cardRow");

diff --git a/scripts/details-popup/subject-display.js b/scripts/details-popup/subject-display.js
@@ -323,8 +323,12 @@
 				if (this.autoplayAudio && this.type === "vocabulary")
 					playSubjectAudio(this.subject["pronunciation_audios"], null);
 
-				if (this.detailsPopup.firstChild)
+				console.log(this.detailsPopup, this.detailsPopup.firstChild);
+				if (!this.expanded && this.detailsPopup.firstChild)
 					this.detailsPopup.firstChild.remove();
+				else
+					Array.from(this.detailsPopup.querySelectorAll(".sd-focusPopup_kanji")).forEach(elem => elem.remove());
+
 				this.detailsPopup.appendChild(this.charContainer(subject, save));
 
 				// srs stage border
@@ -415,7 +419,7 @@
 							</div>
 						</div>
 					`;
-					this.detailsPopup.insertAdjacentHTML("afterbegin", sidebar);
+					this.detailsPopup.insertAdjacentHTML("beforeend", sidebar);
 					this.sidebar = this.detailsPopup.querySelector(".sd-detailsPopup_sidebar");
 				});
 			}