Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Feature/cert layout #12

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Feature/cert layout #12

merged 6 commits into from
Jan 16, 2024

Conversation

mattdean-digicatapult
Copy link
Contributor

Implements a basic layout using grid and subgrid:

Screenshot 2024-01-15 at 16 52 40

A few notes:

  • probably need to move subgrid functionality to grid component in component library
  • subgrid should allow the button for submitting the form to co-exist with the form itself which should make submitting much easier
  • removed @babel/plugin-proposal-class-properties as apparently it's no longer needed or maintained

@mattdean-digicatapult mattdean-digicatapult marked this pull request as ready for review January 15, 2024 17:07
@mattdean-digicatapult mattdean-digicatapult requested a review from a team as a code owner January 15, 2024 17:07
n3op2
n3op2 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@n3op2 n3op2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see a left hand side bar for a ...

.... a timeline:) component

Nice one for including a logo

would debate when v0.1.0 is... I guess with the home page

@mattdean-digicatapult mattdean-digicatapult merged commit fc643a2 into main Jan 16, 2024
5 checks passed
@mattdean-digicatapult mattdean-digicatapult deleted the feature/cert-layout branch January 16, 2024 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@n3op2 n3op2 n3op2 approved these changes

@dc-andysign dc-andysign Awaiting requested review from dc-andysign

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattdean-digicatapult @n3op2