Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Certificate actions buttons and input fields #16

Merged
merged 66 commits into from
Jan 25, 2024

Conversation

dc-andysign
Copy link
Collaborator

@dc-andysign dc-andysign commented Jan 17, 2024


name: Certificate actions buttons
about: Certificate actions buttons including container wrapper and dummy button(s)

Summary

This includes a set of divs that will serve as container wrapper divs for the 3 right-hand side buttons. Those will be added later.

Motivation

Crying on the implementation of the UI

Describe alternatives you've considered

Alternatively I have looked at doing this design ( especially the section on the right ) with divs

function C() {
  return (
      <Sidebar area="sidebar">
        <PaddedDiv>
          <GriddedDiv>
            <Div>SaveDraft</Div>
            <Div>Cancel</Div>
            <DivDouble></DivDouble>
          </GriddedDiv>
        </PaddedDiv>
      </Sidebar>
  )
}

const PaddedDiv = styled.div`
  padding: 34px 21px;
  width: 100%;
`

const GriddedDiv = styled.div`
  display: grid;
  gap: 20px 10px;
  grid-template-columns: 1fr 1fr;
  grid-auto-rows: 44px 69px;
  background-color: #25928b;
`

const Div = styled.div`
  min-width: 132px;

  padding: 1em;
  background-color: #369a93;
  color: #454545;
`

const DivDouble = styled(Div)`
  grid-column: 1 / -1;
`

const BoxDoubleAlternative = styled(Box)`
  grid-column-start: 1;
  grid-column-end: 3;
`

Also this looks also good with

const FlexItem = styled.div`
  // ...
  flex-grow: 1;
`
image image

Additional context

The button area is split into three parts. The top part contains a left-right set of 2 divs while the bottom just one large div.

NEW-ish:

image image image image
image

NEW:

image image image

NEW2:

image

image

image

image

image image

@dc-andysign dc-andysign requested a review from n3op2 January 19, 2024 14:45
@dc-andysign dc-andysign requested a review from a team as a code owner January 24, 2024 09:36
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving as this fixes all the major isues. Well done.

There are some tiny fixes you could do if you want but don't worry

src/pages/components/CertificateTimeInterval.js Outdated Show resolved Hide resolved
src/pages/components/InputFieldDate.js Outdated Show resolved Hide resolved
src/pages/components/InputFieldDate.js Outdated Show resolved Hide resolved
src/pages/components/InputFieldEnergy.js Outdated Show resolved Hide resolved
src/pages/components/InputFieldSize.js Outdated Show resolved Hide resolved
src/pages/components/CertificateForm.js Outdated Show resolved Hide resolved
src/pages/components/InputFieldTime.js Outdated Show resolved Hide resolved
@dc-andysign dc-andysign merged commit ff7b13e into main Jan 25, 2024
5 checks passed
@rmlearney-digicatapult rmlearney-digicatapult deleted the feat/hyp-96-certificate-actions-buttons branch March 11, 2024 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants