feat: enable usage in both CommonJS and ESM environments #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested a packed version of this branch in comapeo-mobile + comapeo-desktop and things seem to be working well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumption of this module is used in a variety of environments where the tooling for module resolution is quite varied e.g:
Ideally I wanted to keep this module purely as an ESM-only module, but in early attempts of integrating with our applications (especially React Native), I've found it quite tedious to deal with the headaches of the tools due to differing support of pure ESM modules. To alleviate this headache, this PR introduces tshy to set up dual publishing of both ESM and CommonJS. It's quite opinionated but it works sufficiently for the needs of this module.