-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add basic github workflow #208
Conversation
fe0e1c3
to
dd4b9e8
Compare
69b7ea7
to
4547498
Compare
c064690
to
4c7e73f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally subjective, but: I think we should merge this such that CI passes, even if the tests are incomplete. I would do this by running npm run lint:prettier
and npm test
(which pass) instead of lint:types
.
Later, we should fix types & ESLint, then enable them in CI.
Just my opinion. I think this approach is also reasonable.
any thoughts on running prettier in a separate job, since it applies to both frontend and backend? currently laid out such that there are separates jobs for backend and frontend checks. |
No preference as long as there's no way for Prettier mistakes to slip through. Maybe a separate job for tasks that apply to both? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's probably a way to de-duplicate some of the setup steps that are shared by these jobs but can look into it as a follow-up
note to self: look into composite actions
Towards #56
Introduces a basic github action that runs on non-draft PRs.
Currently only does typechecking for both backend and frontend.Does the following checks for now:
ESLint (for all) and typechecking (for frontend) to be done as a follow-up