-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade eslint configuration #897
base: develop
Are you sure you want to change the base?
Conversation
cbf782a
to
4994618
Compare
@@ -164,7 +167,8 @@ | |||
"rimraf": "5.0.5", | |||
"semver": "7.6.0", | |||
"type-fest": "4.26.0", | |||
"typescript": "5.3.3" | |||
"typescript": "5.3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we'd try to update TypeScript here but not strictly necessary to. Open to doing though.
src/frontend/hooks/server/maps.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint autofix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint autofix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint autofix
src/frontend/lib/utils.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint autofix
4994618
to
51e7de1
Compare
@react-native/eslint-config
) due to compat issues with the typescript eslint plugin it uses internally.--fix
) flag.Remaining items (can be done as follow-ups):
decide whether or not not having rules specific to React Native for now is a blocker. Can spend some time attempting to get it working but would be okay with doing as a follow-up.
adjust the react configuration to omit non-applicable rules (e.g. no need for
dom
)