Feature/check network state #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add snackbar with shortcut to connection settings. |
wkmeijer
requested changes
Jun 12, 2017
There was a problem hiding this comment.
When you re-enable the network and go back to the app too fast the toast that says "Please enable network connection" is shown, even though the network connection was just enabled.
When the network connection is disabled in e.g. mainactivity no error is given, even though it should still update the blockchain.
Develop bugfix
…e-play-store Feature/update readme play store
wkmeijer
requested changes
Jun 13, 2017
app/src/main/res/values/strings.xml
Outdated
| <string name="please_enable_connect_message">Please enable network connection</string> | ||
| <string name="no_connection">No Network</string> | ||
|
|
||
| <string name="go_network_settings">Settings</string> |
There was a problem hiding this comment.
Please change this to "WIFI SETTINGS" so it's more clear where the button will take the users.
|
waiting for #139 for updated translations, |
wkmeijer
approved these changes
Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103
Checks network state in SplashActivity