Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1774: Move german translation mui components #1870

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Jan 16, 2025

Short description

Move translation of mui-components and related components to translation file.
I decided to split this issue, since its really huge (see todo) and adding i18n in some form validation function may not be that trivial and needs some refactoring

Proposed changes

  • add i18n for graphql error map
  • add translations for most of the mui-components (some validation errors are missing)
  • added readme to point out that the keys in "application" namespaces should not be edited, thats why i created a new namespace "applicationForms" for labels that could be changed

TODO

Side effects

  • may break labels for application form, activation, application applicant view, application verification view, card creation, self service portal (koblenz)

Testing

  1. Create an application and create a card from the application for bavarian entitlementcard
  2. Click on the mail links for application creation, application verification and card creation (card was created from application)
  3. Create a koblenz pass within the self service portal
  4. Check all the parts that were mentioned in side effects

Resolved issues

Fixes: #1774

@f1sh1918 f1sh1918 changed the base branch from main to 1774-move-german-translation-to-translation-file January 16, 2025 17:19
@f1sh1918 f1sh1918 force-pushed the 1774-move-german-translation-mui-components branch from 67f1ba4 to 77e88df Compare January 16, 2025 18:36
@f1sh1918 f1sh1918 marked this pull request as ready for review January 20, 2025 08:55
@steffenkleinle steffenkleinle changed the title 1774: move german translation mui components 1774: Move german translation mui components Jan 22, 2025
Base automatically changed from 1774-move-german-translation-to-translation-file to main January 22, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add all german texts to translation file
1 participant