1660: Handle apollo errors #1878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error map to handle non graphql errors
f1sh1918
requested review from
steffenkleinle,
ztefanie and
seluianova
as code owners
f1sh1918
commented
Jan 21, 2025
| title: string | ||
| description?: string | ReactElement | ||
| } | ||
|
|
||
| const getMessageFromApolloError = (error: ApolloError): GraphQLErrorMessage => { | ||
| const defaultMessage = 'Etwas ist schief gelaufen.' | ||
|
|
||
| if (error.networkError) { |
There was a problem hiding this comment.
not sure if everything is still catched. All i tested was catched by DefaultErrorMap
Maybe there is also sth misconfigured so that 403 were classified as NetworkErrors accidently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
We have the issue that all non
GraphlBaseExceptionswill result in the same message to the user and 403 exceptions will be handled as a network error and just result inServer nicht erreichbarProposed changes
networkErrorbut handle all errors which are not graphql errors in adefaultErrorMapand check for the particular error code and send the matching error messageSide effects
Testing
I'm not pretty sure how to test this on staging because, most of the errors were handled before by not showing the function like
PepperSettingsor `ApiTokenSettings``As a dev you can follow the instructions in the related issue to test the error messages
Resolved issues
Fixes: #1660