2990: Open external links in new tab #3044
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
requested review from
f1sh1918,
LeandraH,
bahaaTuffaha and
lunars97
as code owners
steffenkleinle
force-pushed
the
2990-external-links-new-tab
branch
from
adf7d6a to
0bb0215
Compare
steffenkleinle
commented
Jan 22, 2025
| @@ -17,176 +14,24 @@ import { | |||
| hideIframe, | |||
| preserveIFrameSourcesFromContent, | |||
| } from '../utils/iframes' | |||
|
|
|||
| const SandBox = styled.div<{ $centered: boolean; $smallText: boolean }>` | |||
There was a problem hiding this comment.
Just moved this to a separate component, no changes made
steffenkleinle
force-pushed
the
2990-external-links-new-tab
branch
3 times, most recently
from
48d3eeb to
073a25b
Compare
steffenkleinle
force-pushed
the
2990-external-links-new-tab
branch
from
073a25b to
e21792d
Compare
lunars97
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Something is not working right. When I click on external links for ex., Open in Google Maps or by clicking on the website link, it is not opening a new tab with external website source, and some internal files' url like pdf are being cut off and therefore the files are not being found...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Open external links in new tab and do some refactoring.
Proposed changes
navigateand use it directlySide effects
N/A
Testing
Open all different kinds of links both in the remote content as well as anywhere in the app (e.g. footer, header, ...).
Resolved issues
Fixes: #2990