Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu item "contact" to navigation bar #2981

Merged
merged 3 commits into from
Aug 11, 2024

Conversation

theresantonie
Copy link
Contributor

Short description

The PR adds the menu item "contacts" to the navigation bar for the new feature "contacts information"

Proposed changes

Side effects

  • Unblock other issues of the meta issue

Resolved issues

Fixes: #2951


Pull Request Review Guidelines

Copy link

codeclimate bot commented Aug 8, 2024

Code Climate has analyzed commit 6c18e76 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 83.3% (0.0% change).

View more on Code Climate.

@JoeyStk
Copy link
Contributor

JoeyStk commented Aug 8, 2024

Other than that it looks good! Thank you very much 🙏

@theresantonie theresantonie marked this pull request as ready for review August 10, 2024 18:15
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Looks great! :)

@JoeyStk JoeyStk added the prio: high Needs to be resolved ASAP. label Aug 11, 2024
integreat_cms/cms/templates/_base.html Outdated Show resolved Hide resolved
@JoeyStk JoeyStk merged commit 934a33e into develop Aug 11, 2024
5 checks passed
@JoeyStk JoeyStk deleted the feature/add_contacts_navigation branch August 11, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high Needs to be resolved ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new menu item "Contact" to the navigation side bar
3 participants