Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for contact actions #3283

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Add tests for contact actions #3283

merged 1 commit into from
Dec 17, 2024

Conversation

MizukiTemma
Copy link
Member

Short description

This PR adds test for archiving, deleting and restoring of contact objects.

Proposed changes

  • Test archiving, deleting and restoring one contact object
  • Test bulk archiving, deleting and restoring

Side effects

  • The existing tests of the model functions are moved to another file, as they are rather test for "the model" than the user view/action
  • Protection of used contacts is not (yet) tested in this PR. We can either merge this PR first and adjust the relevant parts in Prevent orphaned contact cards #3282 or we wait for Prevent orphaned contact cards #3282 and do adjustment here.

Resolved issues

Fixes: #3245


Pull Request Review Guidelines

@MizukiTemma MizukiTemma changed the title Test/contact actions Add tests for contact actions Dec 9, 2024
Copy link
Contributor

@charludo charludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉

Protection of used contacts is not (yet) tested in this PR. We can either merge this PR first and adjust the relevant parts in #3282 or we wait for #3282 and do adjustment here.

Definitely merge this one first. The other one additionally depends on the TinyMCE PR.

@MizukiTemma MizukiTemma added the effort: low Should be doable in <4h label Dec 13, 2024
Copy link
Contributor

@lunars97 lunars97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :) Works as expected 🚀

@MizukiTemma MizukiTemma merged commit 6480606 into develop Dec 17, 2024
5 checks passed
@MizukiTemma MizukiTemma deleted the test/contact_actions branch December 17, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Should be doable in <4h
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for contact actions
3 participants