Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to select shown contact details #3320

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

charludo
Copy link
Contributor

@charludo charludo commented Jan 8, 2025

Short description

This PR allows users to choose which contact details are shown when they insert a contact into TinyMCE, as well as when updating the contact later on.

Proposed changes

  • use a GET parameter to encode which contact details should be shown on a per-contact-card basis
  • show appropriate checkboxes after selecting a contact through Tomselect

Side effects

  • styling the checkboxes was... a challenge, since I frustratingly was not able to target them through the tinymce.css file - if someone knows why/how to fix this, I am all ears!
  • suboptimal from a UX perspective: if a user selects a contact, deselects some details, then chooses a different contact, the details selection is reset. Not sure if this is worth the effort to change, though, since the shown checkboxes are necessarily contact-specific

Resolved issues

Fixes: #3258


Pull Request Review Guidelines

@charludo charludo marked this pull request as draft January 8, 2025 07:59
@charludo charludo force-pushed the enhancement/choose-shown-contact-details branch from 3f963cb to a2dc458 Compare January 11, 2025 08:18
@charludo charludo marked this pull request as ready for review January 11, 2025 08:19
@charludo charludo force-pushed the enhancement/choose-shown-contact-details branch from a2dc458 to 16a1f3d Compare January 17, 2025 07:36
@JoeyStk JoeyStk self-assigned this Jan 21, 2025
@JoeyStk
Copy link
Contributor

JoeyStk commented Jan 21, 2025

suboptimal from a UX perspective: if a user selects a contact, deselects some details, then chooses a different contact, the details selection is reset. Not sure if this is worth the effort to change, though, since the shown checkboxes are necessarily contact-specific

This might be a question for @osmers :)

Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

styling the checkboxes was... a challenge, since I frustratingly was not able to target them through the tinymce.css file - if someone knows why/how to fix this, I am all ears!

I don't, but I think it's still readable and understandable, so I would be okay with leaving it as is :)

@osmers
Copy link

osmers commented Jan 21, 2025

suboptimal from a UX perspective: if a user selects a contact, deselects some details, then chooses a different contact, the details selection is reset. Not sure if this is worth the effort to change, though, since the shown checkboxes are necessarily contact-specific

This might be a question for @osmers :)

I don't see a problem with that - it's actually something I would expect, as for a new contact I might want to choose different details to show. So no need to change that from my pov.

Copy link
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thank you so much 😸

Please merge this PR after the release 2025.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to choose what contact details are shown when inserting contacts in TinyMCE
4 participants