-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to select shown contact details #3320
base: develop
Are you sure you want to change the base?
Conversation
3f963cb
to
a2dc458
Compare
a2dc458
to
16a1f3d
Compare
This might be a question for @osmers :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
styling the checkboxes was... a challenge, since I frustratingly was not able to target them through the tinymce.css file - if someone knows why/how to fix this, I am all ears!
I don't, but I think it's still readable and understandable, so I would be okay with leaving it as is :)
I don't see a problem with that - it's actually something I would expect, as for a new contact I might want to choose different details to show. So no need to change that from my pov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thank you so much 😸
Please merge this PR after the release 2025.1.0
Short description
This PR allows users to choose which contact details are shown when they insert a contact into TinyMCE, as well as when updating the contact later on.
Proposed changes
Side effects
tinymce.css
file - if someone knows why/how to fix this, I am all ears!Resolved issues
Fixes: #3258
Pull Request Review Guidelines