Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uNetworking/uWebSockets.js 20.51.0 #70

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

nigrosimone
Copy link
Contributor

@nigrosimone nigrosimone commented Nov 24, 2024

Update uNetworking/uWebSockets.js at 20.51.0 with support for NodeJs 23

Copy link

pkg-pr-new bot commented Nov 24, 2024

Open in Stackblitz

npm i https://pkg.pr.new/dimdenGD/ultimate-express@70

commit: db7e9d7

@nigrosimone nigrosimone changed the title uWebSocket 20.50.0 uNetworking/uWebSockets.js 20.50.0 Nov 24, 2024
@nigrosimone

This comment was marked as outdated.

@dimdenGD
Copy link
Owner

revert package-lock change, remove node 23 as its not supported by uws

@nigrosimone

This comment was marked as outdated.

@nigrosimone

This comment was marked as outdated.

@cesco69
Copy link
Contributor

cesco69 commented Nov 25, 2024

Side note. uNetworking/uWebSockets.js 20.50.0 with Node 23 is a bit faster

Requests/sec vs express

uNetworking/uWebSockets.js 20.50.0 - NodeJs 23:    10.54x faster
uNetworking/uWebSockets.js 20.49.0 - NodeJs 22:    10.03x faster

@cesco69
Copy link
Contributor

cesco69 commented Nov 25, 2024

@nigrosimone and @dimdenGD

I have debug this script with both version

const express = require("../src/index");

const app = express();

app.get('/:test', (req, res) => {
  res.send(req.params.test); // -------------> undefined
})

app.listen(13333, () => {
  console.log("Server is running at http://localhost:13333");
});

when call GET /xxx in 20.49.0 the request is handled by _registerUwsRoute, in 20.50.0 the request is handled by createRequestHandler

image

in 20.50.0 req.optimizedParams into router.js _preprocessRequest() is undefined

@nigrosimone
Copy link
Contributor Author

v20.50.0 is broken! v20.51.0 works!

@nigrosimone nigrosimone changed the title uNetworking/uWebSockets.js 20.50.0 uNetworking/uWebSockets.js 20.51.0 Nov 26, 2024
@maxpain
Copy link

maxpain commented Nov 26, 2024

When will it be merged?

@dimdenGD dimdenGD merged commit eaa5b82 into dimdenGD:main Nov 26, 2024
7 checks passed
@nigrosimone nigrosimone deleted the patch-1 branch November 26, 2024 11:16
@nigrosimone
Copy link
Contributor Author

@dimdenGD there are sono differences into benchmark?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants