-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OpenOceanV2 on Metis #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jeff-CCH
commented
Nov 13, 2023
•
edited
Loading
edited
- OpenOpcean logic
- test
- yarn changeset
Jeff-CCH
changed the title
feat: support OpenOceanV2 on Metis
Support OpenOceanV2 on Metis
Nov 13, 2023
Jeff-CCH
force-pushed
the
feat/integrate-open-ocean
branch
from
November 13, 2023 02:28
4f45a1e
to
0beab0c
Compare
zodahu
reviewed
Nov 14, 2023
chouandy
reviewed
Nov 14, 2023
Jeff-CCH
force-pushed
the
feat/integrate-open-ocean
branch
from
November 15, 2023 01:20
0beab0c
to
1b1cb4d
Compare
zodahu
reviewed
Nov 15, 2023
Jeff-CCH
force-pushed
the
feat/integrate-open-ocean
branch
from
November 15, 2023 01:51
1b1cb4d
to
d016d8c
Compare
zodahu
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chouandy
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.