feat : string possibility with interact #1199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nirbose
reviewed
Feb 5, 2024
key2peace
reviewed
Feb 5, 2024
Comment on lines
+360
to
+376
| * Rename channel | ||
| * | ||
| * @param string $name | ||
| * @return ExtendedPromiseInterface | ||
| */ | ||
| public function rename(string $name): ExtendedPromiseInterface | ||
| { | ||
| if ($this->name === $name) { | ||
| return reject(new InvalidOverwriteException('The name is already set in the channel.')); | ||
| } | ||
|
|
||
| $this->name = $name; | ||
| return $this->http->patch(Endpoint::bind(Endpoint::CHANNEL, $this->id),[ | ||
| 'name' => $this->name | ||
| ]); | ||
| } | ||
|
|
There was a problem hiding this comment.
This should be in a separate PR
There was a problem hiding this comment.
I disagree with this, there is already $channel->name setter and save()
we cant let adding every function for changing every simple attribute like this
people would make multiple different http calls just to update a channel information
SQKo
requested changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtlety, but which allows a tremendous time-saving on large bot projects with this API :)