Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InteractionResponses): mark replied true for followUps #10688

Merged
merged 4 commits into from
Jan 12, 2025

Conversation

imnaiyar
Copy link
Contributor

@imnaiyar imnaiyar commented Jan 4, 2025

Please describe the changes this PR makes and why it should be merged:
followUp(s) don't mark <Interaction>.replied to true (maybe under the assumptions that it is used after replying). But it can also be used immediately after a defer.

Consider the following snippet

await interaction.deferReply();
// ...

await interaction.followUp(...);

if (interaction.replied) .. // This chek will fail even though it is replied

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@imnaiyar imnaiyar requested a review from a team as a code owner January 4, 2025 20:09
Copy link

vercel bot commented Jan 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2025 9:48pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2025 9:48pm

@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Jan 12, 2025
@kodiakhq kodiakhq bot merged commit 101bef1 into discordjs:main Jan 12, 2025
7 checks passed
Jiralite added a commit that referenced this pull request Jan 12, 2025
fix: mark replied true for followUps

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants