UX: Tweak JS height calculation logic #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
force-pushed
the
js-height
branch
2 times, most recently
from
e0ce388 to
ca7fc50
Compare
janzenisaac
approved these changes
Dec 22, 2023
- Moves the height calculation to the wrapper element so we don't need to re-calculate for every list - Instead of enumerating the sibling elements, calculate an `--kanban-offset` value for the top of the wrapper, and then use css viewport height to work out how much space is remaining - Set a minimum of 500px so that the kanban is still usable on sites with very large headers/footers.
davidtaylorhq
force-pushed
the
js-height
branch
from
ca7fc50 to
7c5dbde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--kanban-offsetvalue for the top of the wrapper, and then use css viewport height to work out how much space is remaining