DEV: Build base images for ARM64 platform in a seperate daily job #744
Conversation
tgxworld
force-pushed
the
build_arm_images_daily
branch
3 times, most recently
from
2724164 to
d2447d1
Compare
| @@ -0,0 +1,138 @@ | |||
| on: | |||
| pull_request: | |||
There was a problem hiding this comment.
Enabling it on pull requests first so that we run the job in this PR and I know I got things right. Will remove before merging.
| env: | ||
| BUILDKIT_PROGRESS: plain | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
There is alot of duplication between this new workflow and build.yml but I want to get things running and see if we can even run everything in a reasonable amount of time first.
|
My preference would be to keep things as-is, so that we continue to get feedback on the ARM build in PRs/commits. If we have a time-sensitive change, we can still choose to merge before it completes. If we do decide to proceed with this approach, I think we should avoid duplicating the workflow definition, and instead add a conditional to the existing ARM job. We do something similar in plugin/theme workflows here. So in this case, to ignore push/pr events, we could do something like: aarch64:
if: ${{ github.event_name == 'schedule' }} |
tgxworld
force-pushed
the
build_arm_images_daily
branch
4 times, most recently
from
166f117 to
a07ef89
Compare
Why this change? We're currently building a base image for arm64 platforms as part of the CI workflow. However, building it on Github action via emulation is too slow and makes it meaningless to include as part of the CI workflow. What does this change do? This change moves the building of the bage image targeting the arm64 platform completely to a scheduled job that runs outside of the normal CI workflow. This will also enable us to build the images for the test and dev environment eventually as part of the workflow which we intend to do in a follow up commit.
tgxworld
force-pushed
the
build_arm_images_daily
branch
from
a07ef89 to
efd4424
Compare
|
No longer required because we have access to Github hosted ARM runners now. |
Why this change?
We're currently building a base image for arm64 platforms as part of the
CI workflow. However, building it on Github action via emulation is too
slow and makes it meaningless to include as part of the CI workflow.
What does this change do?
This change moves the building of the bage image targeting the arm64
platform completely to a scheduled job that runs outside of the normal
CI workflow. This will also enable us to build the images for the test
and dev environment eventually as part of the workflow which we intend
to do in a follow up commit.