Move nginx installation into another build step #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
install_nginx
branch
from
a0b746b to
fd6bdae
Compare
Avoids polluting the main image with nginx's build dependencies
tgxworld
force-pushed
the
install_nginx
branch
from
fd6bdae to
d3f63b4
Compare
CvX
approved these changes
Dec 17, 2024
tgxworld
added a commit
that referenced
this pull request
Dec 19, 2024
This reverts commit d963389. This broke certain assumptions like the `/etc/nginx` directory exists.
tgxworld
added a commit
that referenced
this pull request
Dec 19, 2024
featheredtoast
added a commit
that referenced
this pull request
Jan 8, 2025
featheredtoast
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids polluting the main image with nginx's build dependencies