-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #40
Open
eldo-greshard
wants to merge
11
commits into
divio:master
Choose a base branch
from
eldo-greshard:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Develop #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid the user manager error for custom user who use abstract user.
prevent user password changed when build user prever to let password as it is on the client side
settings.SSO_HOME_REDIRECT on LogoutClassView settings.SSO_DASHBOARD_REDIRECT on LoginClassView
try to fix itsdangerous error when try to reach sso server addres. fix type still temporary with no information to user, when itsdangerous can't get any token, it will redirect to sso client web. should define SSO_CLIENT in settings file
@Karmael thank you very much and sorry for the late response. Would you be able to resolve the conflicts and add tests for it? |
hey man, I'll write test for it and try to resolve the problem |
That would be awesome @Karmael |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when i implement this code to my project, it should have to have the same auth_user_mode on settings between client and server. so if my client using custom user auth it throw this.
Error :
django-simple-sso authorization
Manager isn't available; 'auth.User' has been swapped for 'users.User'
and the other problem is, when i tried to login to django admin it throw error that credential error with the same password, and lately i found out that the build user function set the password to unusable_password.