The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, giraffate/clippy-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

[clippy] reported by reviewdog 🐶 warning: field `color_scheme` is never read --> src/note/mod.rs:62:9 | 57 | MdFile { | ------ field in this variant ... 62 | color_scheme: ColorScheme, | ^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default Raw Output: src/note/mod.rs:57:5:w:warning: field `color_scheme` is never read --> src/note/mod.rs:62:9 | 57 | MdFile { | ------ field in this variant ... 62 | color_scheme: ColorScheme, | ^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default __END__

[clippy] reported by reviewdog 🐶 warning: unnecessary map_err on constructor Err(_) --> src/config/external_commands/cmd_template.rs:17:20 | 17 | return Err(KdlNodeErrorType { | ____________________^ 18 | | err_span: *value.span(), 19 | | description: "node expected to have at least 1 argument".to_string(), 20 | | }) 21 | | .map_err(Into::<miette::Report>::into)?; | |__________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_on_constructor = note: `#[warn(clippy::unnecessary_map_on_constructor)]` on by default help: try | 17 ~ return Err(Into::<miette::Report>::into(KdlNodeErrorType { 18 + err_span: *value.span(), 19 + description: "node expected to have at least 1 argument".to_string(), 20 ~ }))?; | Raw Output: src/config/external_commands/cmd_template.rs:17:20:w:warning: unnecessary map_err on constructor Err(_) --> src/config/external_commands/cmd_template.rs:17:20 | 17 | return Err(KdlNodeErrorType { | ____________________^ 18 | | err_span: *value.span(), 19 | | description: "node expected to have at least 1 argument".to_string(), 20 | | }) 21 | | .map_err(Into::<miette::Report>::into)?; | |__________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_on_constructor = note: `#[warn(clippy::unnecessary_map_on_constructor)]` on by default help: try | 17 ~ return Err(Into::<miette::Report>::into(KdlNodeErrorType { 18 + err_span: *value.span(), 19 + description: "node expected to have at least 1 argument".to_string(), 20 ~ }))?; | __END__

[clippy] reported by reviewdog 🐶 warning: called `unwrap` on `body` after checking its variant with `is_some` --> src/note/skim_item/preview/details.rs:95:34 | 94 | if body.is_some() { | ----------------- help: try: `if let Some(..) = body` 95 | string.push_str(&body.unwrap()); | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap = note: `#[warn(clippy::unnecessary_unwrap)]` on by default Raw Output: src/note/skim_item/preview/details.rs:95:34:w:warning: called `unwrap` on `body` after checking its variant with `is_some` --> src/note/skim_item/preview/details.rs:95:34 | 94 | if body.is_some() { | ----------------- help: try: `if let Some(..) = body` 95 | string.push_str(&body.unwrap()); | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap = note: `#[warn(clippy::unnecessary_unwrap)]` on by default __END__

[clippy] reported by reviewdog 🐶 warning: returning the result of a `let` binding from a block --> src/note/skim_item.rs:64:9 | 63 | let ansistring = AnsiString::parse(&input); | ------------------------------------------- unnecessary `let` binding 64 | ansistring | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 63 ~ 64 ~ AnsiString::parse(&input) | Raw Output: src/note/skim_item.rs:63:9:w:warning: returning the result of a `let` binding from a block --> src/note/skim_item.rs:64:9 | 63 | let ansistring = AnsiString::parse(&input); | ------------------------------------------- unnecessary `let` binding 64 | ansistring | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 63 ~ 64 ~ AnsiString::parse(&input) | __END__

[clippy] reported by reviewdog 🐶 warning: use of a fallible conversion when an infallible one could be used --> src/main.rs:185:52 | 185 | let surf_bindings = config.keymap.surf.clone().try_into()?; | ^^^^^^^^ help: use: `into` | = note: converting `SurfKeymap` to `Bindings` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default Raw Output: src/main.rs:185:52:w:warning: use of a fallible conversion when an infallible one could be used --> src/main.rs:185:52 | 185 | let surf_bindings = config.keymap.surf.clone().try_into()?; | ^^^^^^^^ help: use: `into` | = note: converting `SurfKeymap` to `Bindings` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default __END__

[clippy] reported by reviewdog 🐶 warning: use of a fallible conversion when an infallible one could be used --> src/main.rs:186:62 | 186 | let checkmark_bindings = config.keymap.checkmark.clone().try_into()?; | ^^^^^^^^ help: use: `into` | = note: converting `CheckmarkKeymap` to `Bindings` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions Raw Output: src/main.rs:186:62:w:warning: use of a fallible conversion when an infallible one could be used --> src/main.rs:186:62 | 186 | let checkmark_bindings = config.keymap.checkmark.clone().try_into()?; | ^^^^^^^^ help: use: `into` | = note: converting `CheckmarkKeymap` to `Bindings` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions __END__

[clippy] reported by reviewdog 🐶 warning: use of a fallible conversion when an infallible one could be used --> src/main.rs:187:54 | 187 | let stack_bindings = config.keymap.stack.clone().try_into()?; | ^^^^^^^^ help: use: `into` | = note: converting `StackKeymap` to `Bindings` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions Raw Output: src/main.rs:187:54:w:warning: use of a fallible conversion when an infallible one could be used --> src/main.rs:187:54 | 187 | let stack_bindings = config.keymap.stack.clone().try_into()?; | ^^^^^^^^ help: use: `into` | = note: converting `StackKeymap` to `Bindings` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions __END__