Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency net.dv8tion:JDA to v5.0.0-beta.18 #122

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 19, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
net.dv8tion:JDA 5.0.0-beta.17 -> 5.0.0-beta.18 age adoption passing confidence

Release Notes

DV8FromTheWorld/JDA (net.dv8tion:JDA)

v5.0.0-beta.18

Overview

This release fixes a race-condition in the default rate-limiter implementation that very rarely resulted in an orphaned rate-limit bucket.

Orphan Rate-Limit Buckets (#​2585)

Sometimes the cleanup of buckets resulted in an active rate-limit bucket being orphaned. This means that the bucket was continuously trying to execute the same request without updating its state.

This release should resolve that problem, fixing the occasional bug where a 429 response was handled incorrectly.

New Thread Model (#​2463)

The default thread model used for the handling of rate-limits has been changed. Instead of using a single scheduled executor, we now make use of an additional elastic pool that automatically scales up and down based on how many buckets run concurrently.

In the previous model, the scheduled executor limited the capabilities by only providing a fixed amount of threads. To handle scaling with larger bots, we simply used 5 threads for each shard. This has been adjusted now to use a shared pool, which scales up and down based on load instead.

Please let us know if you run into any problems with the defaults in your deployments!

New Features

Changes

Bug Fixes

Full Changelog: discord-jda/JDA@v5.0.0-beta.17...v5.0.0-beta.18

Installation

Gradle

repositories {
    mavenCentral()
}
dependencies {
    implementation("net.dv8tion:JDA:5.0.0-beta.18")
}

Maven

<dependency>
    <groupId>net.dv8tion</groupId>
    <artifactId>JDA</artifactId>
    <version>5.0.0-beta.18</version> 
</dependency>

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot merged commit 00a499c into master Nov 19, 2023
2 checks passed
@renovate renovate bot deleted the renovate/net.dv8tion-jda-5.x branch November 19, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant