-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to support for CQL #31
base: master
Are you sure you want to change the base?
Conversation
@gamorejon were you not happy with this code? |
There was a bug in the generated code that I fixed, but it's all working now and we are using in production. |
When I look though the code, it looked just fine I was more concerned about the introduction of a 3rd party include |
Will do. Yeah, the dependency is not ideal -- especially since we don't care about supporting non-string CQL types -- but if it makes you feel better gocql is a low-level package for CQL which all the other ORM-like packages depend on. It's unlikely to be displaced for at least for a few years and TypeInfo is an interface so things still work with any forks. The ScyllaDB guys (they are a Go shop, for everything except the core DB) maintain a fork of gocql for gocqlx which we use and there are no issues. |
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
=======================================
Coverage 66.14% 66.15%
=======================================
Files 3 3
Lines 449 455 +6
=======================================
+ Hits 297 301 +4
- Misses 140 142 +2
Partials 12 12
Continue to review full report at Codecov.
|
Add support for CQL which is used by Cassandra, ScyllaDB, YugeByte, etc. Works similarly to json in that it adds Marshal and Unmarshal methods.