-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package][PySpark] Expose Training and Validation Metrics #11133
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
25a06b8
[python-package][PySpark] Expose Training and Validation Metrics
984bc8e
Renamed xgboost_training_summary.py to summary.py and _XGBoostTrainin…
3e60eec
Add tests for the PySpark XGBoost summary
92d7cec
Remove the pyspark summary tests from test_xgboost_summary.py and put…
84ca33a
Merge branch 'master' into expose-metrics
trivialfis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
"""Xgboost training summary integration submodule.""" | ||
|
||
from dataclasses import dataclass, field | ||
from typing import Dict, List | ||
|
||
|
||
@dataclass | ||
class XGBoostTrainingSummary: | ||
""" | ||
A class that holds the training and validation objective history | ||
of an XGBoost model during its training process. | ||
""" | ||
|
||
train_objective_history: Dict[str, List[float]] = field(default_factory=dict) | ||
validation_objective_history: Dict[str, List[float]] = field(default_factory=dict) | ||
|
||
@staticmethod | ||
def from_metrics( | ||
metrics: Dict[str, Dict[str, List[float]]] | ||
) -> "XGBoostTrainingSummary": | ||
""" | ||
Create an XGBoostTrainingSummary instance from a nested dictionary of metrics. | ||
|
||
Parameters | ||
---------- | ||
metrics : dict of str to dict of str to list of float | ||
A dictionary containing training and validation metrics. | ||
Example format: | ||
{ | ||
"training": {"logloss": [0.1, 0.08]}, | ||
"validation": {"logloss": [0.12, 0.1]} | ||
} | ||
|
||
Returns | ||
------- | ||
A new instance of XGBoostTrainingSummary. | ||
|
||
""" | ||
train_objective_history = metrics.get("training", {}) | ||
validation_objective_history = metrics.get("validation", {}) | ||
return XGBoostTrainingSummary( | ||
train_objective_history, validation_objective_history | ||
) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trivialfis, Could you check this is ok by enabling it by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @trivialfis, I wonder if this default eval dataset is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, it's unlikely someone will train a model without any evaluation.