Set key id on enrollment keys

[jschlyter]

Summary by CodeRabbit

• New Features

  • Enhanced node enrollment process with unique identifiers
  • Improved key generation with optional key identifier support

• Improvements

  • Updated logging for node enrollment to provide more detailed traceability
  • Modified enrollment key generation to include key identifiers

• Technical Updates

  • Updated method signatures in node management system to support more flexible key handling

[coderabbitai]

Walkthrough

The pull request introduces changes to node enrollment handling in the nodeman module. The modifications focus on improving node enrollment identification and logging by introducing a unique ObjectId for each node enrollment. The generate_enrollment_key method in the NodemanServer class is updated to accept an optional key identifier, allowing more flexible key generation. Logging statements in the enrollment process are enhanced to provide more detailed traceability, including the enrollment key identifier in various log messages.

Changes

File	Changes
nodeman/nodes.py	- Added ObjectId import from bson - Introduced node_enrollment_id using ObjectId() - Updated generate_enrollment_key to accept kid parameter - Modified logging in enroll_node to include enrollment_key_id
nodeman/server.py	- Updated generate_enrollment_key method signature to include optional kid parameter - Modified method to pass kid to JWK.generate

Possibly related PRs

• Send enrollment key as JWK #34: Changes to the generate_enrollment_key method handling
• Generic enrollment keys #36: Introduction of TapirNodeEnrollment class for node enrollment
• Enable configurable enrollment key parameters #65: Modifications to enrollment key generation in create_node function

Poem

🐰 A Rabbit's Ode to Node Enrollment 🔑

With ObjectId, we trace each node's way,
Logging keys that dance and play,
Enrollment signatures now shine bright,
Tracking paths with rabbit's might!

Hop hop, debug with glee! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b36b03b and 34b8ed5.

📒 Files selected for processing (2)

• nodeman/nodes.py (6 hunks)
• nodeman/server.py (1 hunks)

🔇 Additional comments (3)

nodeman/server.py (1)

81-83: LGTM! Clean implementation of key ID support.

The changes correctly implement key ID support in the enrollment key generation process, following the JWK specification.

nodeman/nodes.py (2)

7-7: LGTM! Well-structured enrollment key identification.

The implementation correctly:

• Generates a unique ObjectId for each enrollment
• Uses the ID consistently between the enrollment key and database record
• Maintains proper type safety with string conversion

Also applies to: 162-163, 178-178

---

354-358: LGTM! Enhanced logging for better traceability.

The logging changes improve observability by:

• Including enrollment key IDs in signature validation logs
• Adding key thumbprints to data signature logs
• Using appropriate log levels (info for success, warning for failures)

Also applies to: 360-365, 378-380, 382-384, 442-444, 446-448

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.