Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Python 3.11 #22

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Allow Python 3.11 #22

merged 2 commits into from
Nov 20, 2024

Conversation

jschlyter
Copy link
Member

@jschlyter jschlyter commented Nov 20, 2024

Summary by CodeRabbit

  • New Features

    • Added support for Python version 3.11 in the testing matrix.
  • Bug Fixes

    • Updated minimum required Python version from 3.12 to 3.11 in project dependencies.
  • Improvements

    • Enhanced error handling and structure in the key resolution process.

@jschlyter jschlyter requested a review from a team as a code owner November 20, 2024 06:34
Copy link

coderabbitai bot commented Nov 20, 2024

Walkthrough

The changes include updates to the Python version specifications in two files: the GitHub Actions workflow configuration and the pyproject.toml file for the dnstapir project. The workflow now tests against Python versions 3.11, 3.12, and 3.13, while the pyproject.toml file has been modified to set the minimum required Python version to 3.11 from the previous 3.12. Additionally, there are enhancements in the key resolution process within the key_resolver.py file.

Changes

File Change Summary
.github/workflows/test.yml Added Python version "3.11" to the testing matrix.
pyproject.toml Updated Python version from ^3.12 to ^3.11 in dependencies.
dnstapir/key_resolver.py Updated type alias declaration for PublicKey and enhanced resolve_public_key method in CacheKeyResolver.

Poem

In the land of code where rabbits play,
New Python versions hop in today! 🐇
From three point twelve to eleven we leap,
Testing our code, making it neat.
With each little change, our project will thrive,
In this joyful burrow, our code comes alive! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jschlyter jschlyter marked this pull request as draft November 20, 2024 06:35
@jschlyter jschlyter marked this pull request as ready for review November 20, 2024 07:39
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
dnstapir/key_resolver.py (1)

Line range hint 77-86: Implement proper HTTP client cleanup

The httpx.Client() instance should be properly managed to prevent resource leaks. Consider implementing __enter__/__exit__ methods or using contextlib.closing.

Here's the suggested implementation:

 class UrlKeyResolver(CacheKeyResolver):
     def __init__(self, client_database_base_url: str, key_cache: KeyCache | None = None):
         super().__init__(key_cache=key_cache)
         self.client_database_base_url = client_database_base_url
-        self.httpx_client = httpx.Client()
+        self._httpx_client = None
+
+    @property
+    def httpx_client(self) -> httpx.Client:
+        if self._httpx_client is None:
+            self._httpx_client = httpx.Client()
+        return self._httpx_client
+
+    def __del__(self):
+        if self._httpx_client is not None:
+            self._httpx_client.close()
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f387152 and 4e26b71.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • .github/workflows/test.yml (1 hunks)
  • dnstapir/key_resolver.py (1 hunks)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/test.yml
  • pyproject.toml
🔇 Additional comments (2)
dnstapir/key_resolver.py (2)

15-15: LGTM! Type alias declaration is Python 3.11 compatible

The type alias using the | operator for union types is fully compatible with Python 3.11 (introduced in Python 3.10 via PEP 604) and follows modern type hinting practices.


Line range hint 1-86: Implementation is fully compatible with Python 3.11

The codebase demonstrates excellent use of modern Python features that are all compatible with Python 3.11:

  • Type hints and union types
  • Abstract base classes and proper inheritance
  • Context managers for resource management
  • Exception chaining
  • OpenTelemetry integration

Copy link
Contributor

@morkrost morkrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@morkrost morkrost merged commit 5c46643 into main Nov 20, 2024
9 checks passed
@morkrost morkrost deleted the py311 branch November 20, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants